chore: update linters 2024 #2588
Conversation
mxschmitt
force-pushed
the
update-linters-2024
branch
2 times, most recently
from
c244cd2
to
dd6f218
Compare
mxschmitt
force-pushed
the
update-linters-2024
branch
from
dd6f218
to
0c36b2a
Compare
| @@ -2,7 +2,7 @@ | |||
| # See https://pre-commit.com/hooks.html for more hooks | |||
| repos: | |||
| - repo: https://github.com/pre-commit/pre-commit-hooks | |||
| rev: v4.5.0 | |||
| rev: v5.0.0 | |||
There was a problem hiding this comment.
Hooks which we consume from the pre-commit project - they are not shipped automatically so we specify them like that.
| @@ -7,7 +7,7 @@ mypy==1.11.2 | |||
| objgraph==3.6.1 | |||
| Pillow==10.4.0 | |||
| pixelmatch==0.3.0 | |||
| pre-commit==3.4.0 | |||
| pre-commit==3.5.0 | |||
There was a problem hiding this comment.
What is this one? Why is it different from the previous file?
There was a problem hiding this comment.
This is pre-commit - like ESLint - and above are some rules we consume.
| @@ -7,7 +7,7 @@ mypy==1.11.2 | |||
| objgraph==3.6.1 | |||
| Pillow==10.4.0 | |||
| pixelmatch==0.3.0 | |||
| pre-commit==3.4.0 | |||
| pre-commit==3.5.0 | |||
| pyOpenSSL==24.2.1 | |||
There was a problem hiding this comment.
This one does not seem to match the previous file either.
There was a problem hiding this comment.
In both cases the latest version. Seems like its like definitely-typed - so their version can differ.
| pythonVersion = "3.8" | ||
| reportMissingImports = false | ||
| reportTypedDictNotRequiredAccess = false | ||
| reportCallInDefaultInitializer = true | ||
| reportOptionalSubscript = false | ||
| reportUnboundVariable = false | ||
| strictParameterNoneValue = false | ||
| reportIncompatibleVariableOverride = false |
There was a problem hiding this comment.
What is this one? Do we actually want to enable it?
There was a problem hiding this comment.
We override self._loop from being Optional to being not Optional. Mypy doesn't allow it anymore after they enabled this setting. Keeping it disabled seems fine for now imo.
no user facing change yes. |
Fixes #2582
Recent VSCode versions were using more recent versions of Pyright which was showing errors. This updates our linter setup.